safer remote config and oracle requests, plus working tests#12
Open
mooncitydev wants to merge 1 commit intoTypus-Lab:mainfrom
Open
safer remote config and oracle requests, plus working tests#12mooncitydev wants to merge 1 commit intoTypus-Lab:mainfrom
mooncitydev wants to merge 1 commit intoTypus-Lab:mainfrom
Conversation
Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change set tightens a few places that talk to the network and makes the published
testscript something contributors can actually run.Remote typus config (
TypusConfig.default)branchargument before it is embedded in the GitHub raw URL (blocks..,%, and odd characters) so the path cannot be abused when a caller passes untrusted input.response.okbeforejson()and throws a clear error on HTTP failures instead of silently parsing error pages.Oracle price request
pair/tokenTypequery value withencodeURIComponentso struct tags cannot break out of thepairparameter.Tooling
npmoverridesso@mysten/kioskuses the same@mysten/suias the package (matches the existing Yarnresolutionsintent and fixes duplicate-Transactiontype errors under npm).rm -rfinbuildwithrimrafsonpm run buildworks on Windows.src/*path mapping for ts-node, andtest/test_smoke.tswith real unit coverage for the new branch helper and oracle parsing..gitignoresotest/test_smoke.tsis not excluded by the broadtest*.tsrule.Summary: made by mooncitydev